Skip to content

Verify that DynamoDB and DynamoDB stream's shared shapes are kept in sync. #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2020
Merged

Verify that DynamoDB and DynamoDB stream's shared shapes are kept in sync. #1994

merged 3 commits into from
Sep 22, 2020

Conversation

millems
Copy link
Contributor

@millems millems commented Aug 20, 2020

Update the shapes that currently do not match to be in sync.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020 •
edited
Loading

Codecov Report

Merging #1994 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1994      +/-   ##
============================================
+ Coverage     76.62%   76.65%   +0.03%     
  Complexity      225      225              
============================================
  Files          1112     1112              
  Lines         33611    33680      +69     
  Branches       2599     2622      +23     
============================================
+ Hits          25755    25819      +64     
- Misses         6577     6581       +4     
- Partials       1279     1280       +1
Flag Coverage Δ Complexity Δ
#unittests 76.65% <ø> (+0.03%) 225.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...tomization/CodegenCustomizationProcessorChain.java 81.81% <0.00%> (-8.19%) 0.00% <0.00%> (ø%)
...on/awssdk/protocols/ion/AwsIonProtocolFactory.java 72.72% <0.00%> (-5.06%) 0.00% <0.00%> (ø%)
.../software/amazon/awssdk/core/sync/RequestBody.java 90.00% <0.00%> (-3.11%) 0.00% <0.00%> (ø%)
...ftware/amazon/awssdk/codegen/internal/Jackson.java 59.09% <0.00%> (-2.82%) 0.00% <0.00%> (ø%)
...on/awssdk/codegen/internal/DocumentationUtils.java 75.00% <0.00%> (-2.42%) 0.00% <0.00%> (ø%)
...nhanced/dynamodb/extensions/WriteModification.java 52.00% <0.00%> (-2.17%) 0.00% <0.00%> (ø%)
...ices/s3/internal/presigner/DefaultS3Presigner.java 88.88% <0.00%> (-1.92%) 0.00% <0.00%> (ø%)
...rvices/s3/internal/ConfiguredS3SdkHttpRequest.java 46.15% <0.00%> (-1.85%) 0.00% <0.00%> (ø%)
...retry/DefaultTokenBucketExceptionCostFunction.java 50.00% <0.00%> (-1.73%) 0.00% <0.00%> (ø%)
...ced/dynamodb/model/CreateTableEnhancedRequest.java 63.15% <0.00%> (-1.71%) 0.00% <0.00%> (ø%)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6db7d...00cf4ee. Read the comment docs.

@millems millems force-pushed the millem/dynamodb-streams-sync branch from 565d79d to 01a5f11 Compare September 16, 2020 17:25
@millems
Verify that DynamoDB and DynamoDB stream's shared shapes are kept in …
9d071e6 
…sync. Update the shapes that currently do not match to be in sync.
@millems millems force-pushed the millem/dynamodb-streams-sync branch from 01a5f11 to 9d071e6 Compare September 16, 2020 18:37
@joviegas joviegas self-requested a review September 22, 2020 22:15
@millems millems merged commit d4c036d into master Sep 22, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@millems millems deleted the millem/dynamodb-streams-sync branch April 13, 2021 22:25
aws-sdk-java-automation added a commit that referenced this pull request Apr 20, 2022
@aws-sdk-java-automation
Merge pull request #1994 from aws/staging/b1d13bfa-1844-4694-aeb3-c59…
ce755e1 
…85e545651

Pull request: release <- staging/b1d13bfa-1844-4694-aeb3-c5985e545651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joviegas joviegas joviegas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@millems @codecov-commenter @joviegas